Re: r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

2015-09-14 Thread Simon Atanasyan via cfe-commits
Thanks a lot! On Mon, Sep 14, 2015 at 3:49 PM, NAKAMURA Takumi wrote: > Makes sense. I have updated CLANG_TEST_DEPS in r247554. > > On Mon, Sep 14, 2015 at 9:38 PM Simon Atanasyan wrote: >> >> On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi >> wrote: >> > Why is it tested in clang? >> >> Becau

Re: r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

2015-09-14 Thread NAKAMURA Takumi via cfe-commits
Makes sense. I have updated CLANG_TEST_DEPS in r247554. On Mon, Sep 14, 2015 at 9:38 PM Simon Atanasyan wrote: > On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi > wrote: > > Why is it tested in clang? > > Because the problem fixed by r247546 can be reproduced only in case of > using inline ass

Re: r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

2015-09-14 Thread Simon Atanasyan via cfe-commits
On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi wrote: > Why is it tested in clang? Because the problem fixed by r247546 can be reproduced only in case of using inline assembler. And the problem is in the incorrect ELF header flag. So this test cannot be in llvm/test because there is no inline a

Re: r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

2015-09-14 Thread NAKAMURA Takumi via cfe-commits
Why is it tested in clang? FYI, update CLANG_TEST_DEPS in clang/test/CMakeLists.txt, if it would remain in clang/test. On Mon, Sep 14, 2015 at 8:24 PM Simon Atanasyan via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: atanasyan > Date: Mon Sep 14 06:23:02 2015 > New Revision: 247548

r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

2015-09-14 Thread Simon Atanasyan via cfe-commits
Author: atanasyan Date: Mon Sep 14 06:23:02 2015 New Revision: 247548 URL: http://llvm.org/viewvc/llvm-project?rev=247548&view=rev Log: [mips] Add test case to check ABI flag emissions in case of inline assembler Follow up to r247546. The test case reproduces the problem fixed by this commit. Ad