Re: r369217 - [Diagnostics] Diagnose misused xor as pow

2019-08-19 Thread Dávid Bolvanský via cfe-commits
Yes, #define ALPHA_OFFSET 0x3 should turn off the diagnostic. (We skip hex decimals). Dňa 19. 8. 2019 o 20:06 užívateľ Arthur O'Dwyer napísal: >> On Mon, Aug 19, 2019 at 1:53 PM Nico Weber via cfe-commits >> wrote: > >> Hi, >> >> this results in a false positive on webrtc, on this cod

Re: r369217 - [Diagnostics] Diagnose misused xor as pow

2019-08-19 Thread Arthur O'Dwyer via cfe-commits
On Mon, Aug 19, 2019 at 1:53 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > this results in a false positive on webrtc, on this code: > > > https://cs.chromium.org/chromium/src/third_party/libwebp/src/enc/picture_csp_enc.c?q=picture_csp_enc.c&sq=package:chromium&dr&l=

Re: r369217 - [Diagnostics] Diagnose misused xor as pow

2019-08-19 Thread Nico Weber via cfe-commits
Hi, this results in a false positive on webrtc, on this code: https://cs.chromium.org/chromium/src/third_party/libwebp/src/enc/picture_csp_enc.c?q=picture_csp_enc.c&sq=package:chromium&dr&l=1002 The code does this: #ifdef WORDS_BIGENDIAN #define ALPHA_OFFSET 0 // uint32_t 0xff00 is 0xff,0