Thanks! Bots are happy with the reland. Thanks for taking the time to
explain the object library stuff!
*From: *Chris Bieneman
*Date: *Thu, May 16, 2019 at 11:24 PM
*To: *Nico Weber
*Cc: *cfe-commits
I’ll re-land disabling if PIC is off.
>
> This doesn’t replace the static libraries with object
I’ll re-land disabling if PIC is off.
This doesn’t replace the static libraries with object libraries, it just
creates an object library target (named obj.${name}) for each static library.
That allows the objects to be referenced separately from the archives, so we
don’t have to do the -load-al
To not keep the build broken over night, and since it's a small change that
should be easy to reland, I've reverted this for now in r360973.
On Thu, May 16, 2019 at 8:52 PM Nico Weber wrote:
> Hello,
>
> this breaks building with -DLLVM_ENABLE_PIC=OFF. Maybe the new target
> shouldn't be build i
Hello,
this breaks building with -DLLVM_ENABLE_PIC=OFF. Maybe the new target
shouldn't be build in those builds?
Also, if I read this right, this makes static libraries for clang always be
object libraries. Is that correct? If so, this likely makes the normal
clang binary larger and less efficie
