Re: r355182 - [clang-format] [NFC] clang-format the Format library

2019-03-11 Thread Michael Kruse via cfe-commits
Am Sa., 9. März 2019 um 13:54 Uhr schrieb MyDeveloper Day : > > Yes ideally I'd agree, It also says: > > > Avoid committing formatting- or whitespace-only changes outside of code you > > plan to make subsequent changes to. > > This was getting to be a problem, every time we edited the file (with

Re: r355182 - [clang-format] [NFC] clang-format the Format library

2019-03-09 Thread MyDeveloper Day via cfe-commits
Yes ideally I'd agree, It also says: > Avoid committing formatting- or whitespace-only changes outside of code you plan to make subsequent changes to. This was getting to be a problem, every time we edited the file (with auto-clang-format) a large number of other changes would also get made, pres

Re: r355182 - [clang-format] [NFC] clang-format the Format library

2019-03-08 Thread Michael Kruse via cfe-commits
Isn't this kind of commit discouraged?, as by https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > Avoid committing formatting- or whitespace-only changes outside of code you > plan to make subsequent changes to. and the discussion after which this has been added: https://lists.l