Re: r318456 - Issue -Wempty-body warnings for else blocks

2017-11-20 Thread Hans Wennborg via cfe-commits
Reverted in r318667. See coments on the r318556 thread. On Thu, Nov 16, 2017 at 3:32 PM, Richard Smith via cfe-commits wrote: > This is kicking up false positives on code that does the following: > > #define USED(x) if(x);else > // ... > assert(x); > USED(x); > > It's a bit of a weird pattern, b

Re: r318456 - Issue -Wempty-body warnings for else blocks

2017-11-16 Thread Richard Smith via cfe-commits
This is kicking up false positives on code that does the following: #define USED(x) if(x);else // ... assert(x); USED(x); It's a bit of a weird pattern, but it occurs in some open-source code and seems easy enough for us to detect (if the semicolon and the preceding token aren't from the same Fil