Re: r253202 - clang-format: Enable #include sorting by default.

2015-11-16 Thread Daniel Jasper via cfe-commits
Up to you. I am not worried about accidentally breaking it in the foreseeable future. On Mon, Nov 16, 2015 at 8:20 PM, Nico Weber wrote: > i.e. should SortIncludes be false for -style=WebKit for now? > > On Mon, Nov 16, 2015 at 11:19 AM, Nico Weber wrote: > >> Should this be a per-style default

Re: r253202 - clang-format: Enable #include sorting by default.

2015-11-16 Thread Nico Weber via cfe-commits
i.e. should SortIncludes be false for -style=WebKit for now? On Mon, Nov 16, 2015 at 11:19 AM, Nico Weber wrote: > Should this be a per-style default? It still only doesn't break webkit > files only by accident, right? > > On Mon, Nov 16, 2015 at 10:35 AM, Eric Christopher via cfe-commits < > cf

Re: r253202 - clang-format: Enable #include sorting by default.

2015-11-16 Thread Nico Weber via cfe-commits
Should this be a per-style default? It still only doesn't break webkit files only by accident, right? On Mon, Nov 16, 2015 at 10:35 AM, Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > !!! > > Awesome :) > > -eric > > On Mon, Nov 16, 2015 at 4:41 AM Daniel Jasper via cf

Re: r253202 - clang-format: Enable #include sorting by default.

2015-11-16 Thread Eric Christopher via cfe-commits
!!! Awesome :) -eric On Mon, Nov 16, 2015 at 4:41 AM Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Mon Nov 16 06:38:56 2015 > New Revision: 253202 > > URL: http://llvm.org/viewvc/llvm-project?rev=253202&view=rev > Log: > clang-format: Enable #i