Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

2015-11-13 Thread Aaron Ballman via cfe-commits
On Thu, Nov 12, 2015 at 8:51 PM, Argyrios Kyrtzidis wrote: > I assume you are referring to the install-c-index-test target, this should > not be added to IDEs after r253001. Indeed, it is fixed for me now. Thank you! ~Aaron > >> On Nov 12, 2015, at 7:29 AM, Aaron Ballman wrote: >> >> Is this

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

2015-11-12 Thread Argyrios Kyrtzidis via cfe-commits
I assume you are referring to the install-c-index-test target, this should not be added to IDEs after r253001. > On Nov 12, 2015, at 7:29 AM, Aaron Ballman wrote: > > Is this target needed by IDEs? It currently adds the target to the > root level of the solution in MSVC. > > ~Aaron > > On Wed

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

2015-11-12 Thread Argyrios Kyrtzidis via cfe-commits
Thanks for pointing it out. r253001 sets up the destination to a different location only if ‘INTERNAL_INSTALL_PREFIX’ is set. > On Nov 12, 2015, at 5:50 AM, Ismail Donmez wrote: > > Fixed in r252890 > > On Thu, Nov 12, 2015 at 2:17 PM, Ismail Donmez > wrote: > Hi, > >

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

2015-11-12 Thread Aaron Ballman via cfe-commits
Is this target needed by IDEs? It currently adds the target to the root level of the solution in MSVC. ~Aaron On Wed, Nov 11, 2015 at 7:46 PM, Argyrios Kyrtzidis via cfe-commits wrote: > Author: akirtzidis > Date: Wed Nov 11 18:46:57 2015 > New Revision: 252836 > > URL: http://llvm.org/viewvc/ll

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

2015-11-12 Thread Ismail Donmez via cfe-commits
Fixed in r252890 On Thu, Nov 12, 2015 at 2:17 PM, Ismail Donmez wrote: > Hi, > > On Thu, Nov 12, 2015 at 2:46 AM, Argyrios Kyrtzidis via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> --- cfe/trunk/tools/c-index-test/CMakeLists.txt (original) >> +++ cfe/trunk/tools/c-index-test/CMakeLis

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

2015-11-12 Thread Ismail Donmez via cfe-commits
Hi, On Thu, Nov 12, 2015 at 2:46 AM, Argyrios Kyrtzidis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > --- cfe/trunk/tools/c-index-test/CMakeLists.txt (original) > +++ cfe/trunk/tools/c-index-test/CMakeLists.txt Wed Nov 11 18:46:57 2015 > @@ -28,3 +28,12 @@ if (CLANG_HAVE_LIBXML) >inc