Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-20 Thread Benjamin Kramer via cfe-commits
Put it back in r250803. Tests very welcome ;) - Benjamin On Tue, Oct 20, 2015 at 9:14 AM, Michael Gottesman via cfe-commits wrote: > Let me play with it a bit (I did not read the code, I just was tracking down > the linkage error). > > Michael > > On Oct 20, 2015, at 12:07 AM, Chandler Carruth

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-20 Thread Michael Gottesman via cfe-commits
Let me play with it a bit (I did not read the code, I just was tracking down the linkage error). Michael > On Oct 20, 2015, at 12:07 AM, Chandler Carruth wrote: > > Is it possible to add a unittest that exercises this extension point in-tree? > For example the way I did for AA extension hooks

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-20 Thread Chandler Carruth via cfe-commits
Is it possible to add a unittest that exercises this extension point in-tree? For example the way I did for AA extension hooks? On Mon, Oct 19, 2015 at 9:00 PM Michael Gottesman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits <

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-20 Thread Michael Gottesman via cfe-commits
> On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits >> wrote: >> >> Author: d0k >> Date: Thu Oct 15 10:29:40 2015 >> New Revision: 250418 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=250418&vie

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-19 Thread Michael Gottesman via cfe-commits
> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Thu Oct 15 10:29:40 2015 > New Revision: 250418 > > URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev > Log: > [CodeGen] Remove dead code. NFC. > > Modified: >cfe/trunk/lib/CodeGen/C

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-15 Thread Benjamin Kramer via cfe-commits
On Thu, Oct 15, 2015 at 6:12 PM, Adrian Prantl wrote: > >> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits >> wrote: >> >> Author: d0k >> Date: Thu Oct 15 10:29:40 2015 >> New Revision: 250418 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev >> Log: >> [CodeGen] Re

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-15 Thread Adrian Prantl via cfe-commits
> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Thu Oct 15 10:29:40 2015 > New Revision: 250418 > > URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev > Log: > [CodeGen] Remove dead code. NFC. > > Modified: >cfe/trunk/lib/CodeGen/C