Re: Attribute spelling policy

2017-10-23 Thread Aaron Ballman via cfe-commits
On Mon, Oct 23, 2017 at 11:16 AM, Arthur O'Dwyer wrote: > On Mon, Oct 23, 2017 at 7:33 AM, Aaron Ballman via cfe-commits > wrote: >> >> On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote: >> > On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote: >> >> >> >> Attributes come with multiple s

Re: Attribute spelling policy

2017-10-23 Thread Arthur O'Dwyer via cfe-commits
On Mon, Oct 23, 2017 at 7:33 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote: > > On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote: > >> > >> Attributes come with multiple spelling flavors, but when it comes to

Re: Attribute spelling policy

2017-10-23 Thread Aaron Ballman via cfe-commits
On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote: > > On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote: >> >> Attributes come with multiple spelling flavors, but when it comes to >> adding new attributes that are not present in other compiler tools >> such as GCC or MSVC, we have done

Re: Attribute spelling policy

2017-10-23 Thread Hal Finkel via cfe-commits
On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote: Attributes come with multiple spelling flavors, but when it comes to adding new attributes that are not present in other compiler tools such as GCC or MSVC, we have done a poor job of being consistent with which spelling flavors we ado

Re: Attribute spelling policy

2017-10-22 Thread Saleem Abdulrasool via cfe-commits
Very much a +1 on having attributes map in via `__attribute__` and `[[clang::]]` uniformly when appropriate. On Sat, Oct 21, 2017 at 8:14 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Attributes come with multiple spelling flavors, but when it comes to > adding new attr