Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Sorry for the delay -- didn't see this email come in. Committed as r248595. :) On Tue, Sep 22, 2015 at 1:06 PM, Ettore Speziale wrote: > Hello, > > > Looks good to me! > > > > Do you have commit access, or would you like for me to commit it for you? > > I do not have commit access. It would be

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Hello, > Looks good to me! > > Do you have commit access, or would you like for me to commit it for you? I do not have commit access. It would be great if you can commit for me. Thanks, Ettore Speziale ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Looks good to me! Do you have commit access, or would you like for me to commit it for you? George On Tue, Sep 22, 2015 at 7:45 AM, Ettore Speziale wrote: > Hello, > > > It looks like the attached patch is the same as the original one? > > I’ve attache the wrong patch. Here is the right one: >

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Hello, > It looks like the attached patch is the same as the original one? I’ve attache the wrong patch. Here is the right one: enable-if.diff Description: Binary data Thanks, Ettore Speziale___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

> sorry for the late reply, I did not note this email … No problem! :) It looks like the attached patch is the same as the original one? George On Mon, Sep 21, 2015 at 10:31 AM, Ettore Speziale wrote: > Hello, > > sorry for the late reply, I did not note this email … > > > > Sure. :) Review

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Hello, sorry for the late reply, I did not note this email … > Sure. :) Review is based off the attachment I grabbed from here: > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150824/136904.html That’s correct. > A few nits: > - test/Sema/enable_if.cpp line 24: Please use __attri

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Sure. :) Review is based off the attachment I grabbed from here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150824/136904.html A few nits: - test/Sema/enable_if.cpp line 24: Please use __attribute__(( instead of __attribute(( - Can we have a similar test for a function that returns

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

+gbiv, would you be able to review this? On Sep 14, 2015 7:42 AM, "Ettore Speziale" wrote: > Ping > > > Gently ping. > > > >> On Aug 26, 2015, at 2:40 PM, Ettore Speziale > wrote: > >> > >> Forward to the right ML: > >> > Sorry about the extreme delay. This patch slipped through the cracks,

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Ping > Gently ping. > >> On Aug 26, 2015, at 2:40 PM, Ettore Speziale >> wrote: >> >> Forward to the right ML: >> Sorry about the extreme delay. This patch slipped through the cracks, and I only noticed it again when searching my email for enable_if. Committed in r245985! In

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Gently ping. > On Aug 26, 2015, at 2:40 PM, Ettore Speziale > wrote: > > Forward to the right ML: > >>> Sorry about the extreme delay. This patch slipped through the cracks, and I >>> only noticed it again when searching my email for enable_if. Committed in >>> r245985! In the future, please

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Forward to the right ML: >> Sorry about the extreme delay. This patch slipped through the cracks, and I >> only noticed it again when searching my email for enable_if. Committed in >> r245985! In the future, please feel free to continue pinging weekly! > > NP, thank you for committing the patch