On Thu, 2020-06-04 at 13:06 +0300, Kadir Çetinkaya wrote:
> Hi Mikael,
>
> sent out 4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680, please let me know
> if it helps!
Hi,
Yes, now it's silent.
Thank you!
/Mikael
>
> On Thu, Jun 4, 2020 at 12:40 PM Mikael Holmén via Phabricator <
> revi...@reviews.l
Hi Mikael,
sent out 4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680, please let me know if it
helps!
On Thu, Jun 4, 2020 at 12:40 PM Mikael Holmén via Phabricator <
revi...@reviews.llvm.org> wrote:
> uabelho added inline comments.
>
>
>
> Comment at: clang-tools-extra/clangd/CodeComple
managed to reproduce the issue. sent out https://reviews.llvm.org/D80988
for a fix.
On Tue, Jun 2, 2020 at 12:08 PM Sam McCall wrote:
> On Tue, Jun 2, 2020 at 10:38 AM Kadir Çetinkaya
> wrote:
>
>> Hi Jan,
>>
>> I don't think there's much point in running ReplayPreamble with an empty
>> preambl
On Tue, Jun 2, 2020 at 10:38 AM Kadir Çetinkaya wrote:
> Hi Jan,
>
> I don't think there's much point in running ReplayPreamble with an empty
> preamble, but this should already be a no-op as there can't be any includes
> inside the preamble region if size is 0.
>
> I can't seem to reproduce a fa
Hi Jan,
I don't think there's much point in running ReplayPreamble with an empty
preamble, but this should already be a no-op as there can't be any includes
inside the preamble region if size is 0.
I can't seem to reproduce a failure with the root causes you've provided.
Even when ReplayPreamble:
