Re: [PATCH] D70701: Fix more VFS tests on Windows

2021-01-22 Thread Adrian McCarthy via cfe-commits
BTW, I hope I didn't come across as overly negative in my previous response. I'd love to see the situation improved. I just don't know what that would look like. > One thing I see, but wasn't obvious from your description, is that the mixed/hybrid separator behaviour only happens for `defined(_W

Re: [PATCH] D70701: Fix more VFS tests on Windows

2021-01-21 Thread Adrian McCarthy via cfe-commits
I didn't design VFS. I just fixed a bunch of portability bugs that prevented us from running most of the VFS tests on Windows. If I were designing it, I (hope) I wouldn't have done it this way. But the horse is already out of the barn. Here's my background with VFS (and, specifically, the redi