Re: [PATCH] D63155: [clang][NewPM] Fix broken profile test

On Fri, Jun 28, 2019 at 5:28 PM Xinliang David Li wrote: > I agree that the test coverage needs to be improved eg better check etc. > PGO is rarely run under -O0. But I agree that we should improve the test. I sent out https://reviews.llvm.org/D64029. Chanlder: could you take a look? Thanks,

Re: [PATCH] D63155: [clang][NewPM] Fix broken profile test

I agree that the test coverage needs to be improved eg better check etc. David On Fri, Jun 28, 2019 at 5:21 PM Chandler Carruth via Phabricator via llvm-commits wrote: > chandlerc added a comment. > > In D63155#1563275 , @xur wrote: > > > In D63155#156

Re: [PATCH] D63155: [clang][NewPM] Fix broken profile test

they are not doing the exacly the same thing for old pass manager and new pass manger: old pass manger is doing instrumentation, while the new pass manager with this change is NOT. the test is not check instrumentation, (it only check the variables that generates by InstroProfiling pass). In this s