Re: [PATCH] D46485: Add python tool to dump and construct header maps

2018-06-20 Thread Galina Kistanova via cfe-commits
oso Lopes > *Sent:* Wednesday, June 20, 2018 6:25 PM > *To:* Stella Stamenova > *Cc:* Richard Smith; Duncan Exon Smith; jkor...@apple.com; Michał Górny; > cfe-commits > *Subject:* Re: [PATCH] D46485: Add python tool to dump and construct > header maps > > On Wed, Jun 20,

Re: [PATCH] D46485: Add python tool to dump and construct header maps

2018-06-20 Thread Stella Stamenova via cfe-commits
: Add python tool to dump and construct header maps On Wed, Jun 20, 2018 at 5:42 PM Stella Stamenova wrote: > > Thanks Bruno, > > I ran a build as well and I can see that hmaptool is now in the correct bin > directory. The tests still failed though because on Windows, at least,

RE: [PATCH] D46485: Add python tool to dump and construct header maps

2018-06-20 Thread Stella Stamenova via cfe-commits
dnesday, June 20, 2018 4:14 PM To: Stella Stamenova Cc: Richard Smith ; Duncan Exon Smith ; jkor...@apple.com; mgo...@gentoo.org; cfe-commits Subject: Re: [PATCH] D46485: Add python tool to dump and construct header maps Attempted a fix in r335190, watching the bots. On Wed, Jun 20, 2018 at 3:

Re: [PATCH] D46485: Add python tool to dump and construct header maps

2018-06-20 Thread Bruno Cardoso Lopes via cfe-commits
On Wed, Jun 20, 2018 at 5:42 PM Stella Stamenova wrote: > > Thanks Bruno, > > I ran a build as well and I can see that hmaptool is now in the correct bin > directory. The tests still failed though because on Windows, at least, you > need to explicitly call python to run a script e.g. "python hma

Re: [PATCH] D46485: Add python tool to dump and construct header maps

2018-06-20 Thread Bruno Cardoso Lopes via cfe-commits
Attempted a fix in r335190, watching the bots. On Wed, Jun 20, 2018 at 3:53 PM Bruno Cardoso Lopes wrote: > > Hi Stella, > > On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator > wrote: > > > > stella.stamenova added a comment. > > > > This breaks the clang tests on Windows when buil

Re: [PATCH] D46485: Add python tool to dump and construct header maps

2018-06-20 Thread Bruno Cardoso Lopes via cfe-commits
Hi Stella, On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator wrote: > > stella.stamenova added a comment. > > This breaks the clang tests on Windows when building using Visual Studio as > none of the updated tests can find hmaptool. Yes. I contacted Galina about that but maybe it