Re: [PATCH] D43514: Start settinng dso_local for COFF

2018-02-22 Thread Eric Christopher via cfe-commits
On Thu, Feb 22, 2018 at 4:40 PM Rafael Avila de Espindola via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Eric Christopher via Phabricator writes: > > > echristo added inline comments. > > > > > > > > Comment at: lib/CodeGen/CodeGenModule.h:728 > > + /// This must be call

Re: [PATCH] D43514: Start settinng dso_local for COFF

2018-02-22 Thread Rafael Avila de Espindola via cfe-commits
Eric Christopher via Phabricator writes: > echristo added inline comments. > > > > Comment at: lib/CodeGen/CodeGenModule.h:728 > + /// This must be called after dllimport/dllexport is set. > + /// FIXME: should this set dllimport/dllexport instead? >void setGVProperties(llv