Re: [PATCH] D34992: Emit static constexpr member as available_externally definition

2017-07-05 Thread David Majnemer via cfe-commits
On Wed, Jul 5, 2017 at 12:22 PM Mehdi AMINI wrote: > The LLVM verifier is complaining that dllimport have to be external > linkage and isn't happy with available_externally, is the verifier wrong? > IMO, yes. I imagine that it is fine with dllimport available_externally functions already. > 20

Re: [PATCH] D34992: Emit static constexpr member as available_externally definition

2017-07-05 Thread Mehdi AMINI via cfe-commits
The LLVM verifier is complaining that dllimport have to be external linkage and isn't happy with available_externally, is the verifier wrong? 2017-07-05 9:12 GMT-07:00 David Majnemer : > I don't think you need the dllimport restriction. > > On Wed, Jul 5, 2017 at 12:05 PM Alex Lorenz via Phabrica

Re: [PATCH] D34992: Emit static constexpr member as available_externally definition

2017-07-05 Thread David Majnemer via cfe-commits
I don't think you need the dllimport restriction. On Wed, Jul 5, 2017 at 12:05 PM Alex Lorenz via Phabricator via cfe-commits wrote: > arphaman added a comment. > > Does this apply to all constexpr global variables? It could potentially > fix https://bugs.llvm.org/show_bug.cgi?id=31860 . > > > h