Re: [PATCH] D28672: [ASTMatchers] update doc by running dump_ast_matchers.py

2017-01-15 Thread Aaron Ballman via cfe-commits
On Sun, Jan 15, 2017 at 4:19 PM, Eric Liu wrote: > I've sent an email to cfe-dev (and Tanya) about this. And this patch will be > abandoned since it doesn't fix anything. Thank you for taking care of this! ~Aaron > > On Sun, Jan 15, 2017 at 10:04 PM Aaron Ballman > wrote: >> >> On Sun, Jan 15,

Re: [PATCH] D28672: [ASTMatchers] update doc by running dump_ast_matchers.py

2017-01-15 Thread Eric Liu via cfe-commits
I've sent an email to cfe-dev (and Tanya) about this. And this patch will be abandoned since it doesn't fix anything. On Sun, Jan 15, 2017 at 10:04 PM Aaron Ballman wrote: > On Sun, Jan 15, 2017 at 1:00 PM, Eric Liu via Phabricator > wrote: > > ioeric added a comment. > > > > In https://reviews

Re: [PATCH] D28672: [ASTMatchers] update doc by running dump_ast_matchers.py

2017-01-15 Thread Aaron Ballman via cfe-commits
On Sun, Jan 15, 2017 at 1:00 PM, Eric Liu via Phabricator wrote: > ioeric added a comment. > > In https://reviews.llvm.org/D28672#646336, @malcolm.parsons wrote: > >> In https://reviews.llvm.org/D28672#646151, @aaron.ballman wrote: >> >> > I'm not seeing anything wrong, per se, but why has so much