Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

After some discussion on IRC, we agreed to give https://reviews.llvm.org/D26984 a try. On Tue, Nov 22, 2016 at 11:41 AM, Mehdi Amini wrote: > This has been like that forever, this is not new with 3.9. > Note also that the system ar/ranlib are sensitive to the environment > DYLD_LIBRARY_PATH and

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

This has been like that forever, this is not new with 3.9. Note also that the system ar/ranlib are sensitive to the environment DYLD_LIBRARY_PATH and will look for libLTO appropriately (since they aren’t invoked with clang, we haven’t been able to do any “magic” here yet). — Mehdi > On Nov 22,

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

I would also note that llvm 3.9.x and 4.0svn also require use of their own llvm-ar and llvm-ranlib for archiving under -flto as well (beyond using the matching libLTO.dylib). On Tue, Nov 22, 2016 at 12:59 AM, Mehdi Amini wrote: > Double-checked on the latest binary release on llvm.org, it ships w

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

Double-checked on the latest binary release on llvm.org, it ships with clang+llvm-3.9.0-x86_64-apple-darwin/lib/libLTO.dylib I also can’t find any CMake option that disable LTO support at build time for clang. > On Nov 21, 2016, at 9:53 PM, Mehdi Amini via cfe-commits > wrote: > > AFAIK any

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

AFAIK any clang build open-source ships with libLTO. Not having libLTO built with clang is a Chromium oddity, unless I missed the obvious somewhere. > On Nov 21, 2016, at 9:50 PM, Nico Weber wrote: > > In what way is this chromium specific? It's "all non-xcode uses of clang on > mac", no? >

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

In what way is this chromium specific? It's "all non-xcode uses of clang on mac", no? On Nov 21, 2016 7:29 PM, "Mehdi Amini" wrote: > > On Nov 21, 2016, at 2:44 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini > wrote: > >> >> On Nov 21, 2016, at 2:27 PM, Nico Weber wrot

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On Nov 21, 2016, at 4:29 PM, Mehdi Amini wrote: > >> >> On Nov 21, 2016, at 2:44 PM, Nico Weber > > wrote: >> >> On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini > > wrote: >> >>> On Nov 21, 2016, at 2:27 PM, Nico Weber >>

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On Nov 21, 2016, at 2:44 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini > wrote: > >> On Nov 21, 2016, at 2:27 PM, Nico Weber > > wrote: >> >> On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits >> m

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini wrote: > > On Nov 21, 2016, at 2:27 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits lists.llvm.org> wrote: > >> mehdi_amini added a comment. >> >> In https://reviews.llvm.org/D25932#601842, @rnk wrote: >> >> > I

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On Nov 21, 2016, at 2:27 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > mehdi_amini added a comment. > > In https://reviews.llvm.org/D25932#601842 > , @rnk wrote: >

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits < cfe-commits@lists.llvm.org> wrote: > mehdi_amini added a comment. > > In https://reviews.llvm.org/D25932#601842, @rnk wrote: > > > In https://reviews.llvm.org/D25932#601820, @mehdi_amini wrote: > > > > > We ship `clang + libLTO + ld64`

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

(In addition to rnk's question: We build with -Werror, but Wliblto seems unaffected by this. Because of that, our bots didn't catch the new warning and we only noticed this when a human did a local build after we updated compilers and saw a wall of warnings. It'd be good if Wliblto was affected by

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On 2016-Oct-24, at 21:43, Mehdi AMINI wrote: > > mehdi_amini created this revision. > mehdi_amini added a reviewer: dexonsmith. > mehdi_amini added a subscriber: cfe-commits. > > We're only doing it with -flto currently, however it never "hurt" > to pass it, and users that are linking without