Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-23 Thread Alexander Shaposhnikov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282322: Remove excessive padding from RedeclarableResult (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D24754?vs=71903&id=72388#toc Repository: rL LLVM https://reviews.ll

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Александр Шапошников via cfe-commits
>What's the purpose of this change PaddingChecker generates a report on it, yeah, you are right that it won't save too much (just a little), but it was easy to fix. Another reason why i am doing this - it reduces the number of reports produced by static analyzer (less noisy) - and since it saves sm

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Richard Smith via cfe-commits
What's the purpose of this change? We only put these objects in the stack, and never have many of them at once. If we don't care about size, a natural field order seems preferable to one that minimises padding. On 22 Sep 2016 12:41 pm, "Alexander Shaposhnikov" wrote: > alexshap added inline comm

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) - : FirstID(FirstID), MergeWith(MergeWith), IsKeyDecl(IsKeyDecl) {} +

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) -

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-21 Thread Yaron Keren via cfe-commits
yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. also, gcc warns if order of field initializators is different than the order of fields. Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list cf

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-21 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) - : FirstID(FirstID), MergeWith(MergeWith), IsKeyDecl(IsKeyDecl) {} +

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-21 Thread Vedant Kumar via cfe-commits
vsk added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) - : FirstID(FirstID), MergeWith(MergeWith), IsKeyDecl(IsKeyDecl) {} + Rede

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-20 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. F2435929: Screen Shot 2016-09-20 at 12.19.51 AM.png Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c