rmaprath added inline comments.
Comment at: test/std/re/re.alg/re.alg.search/grep.pass.cpp:25
@@ -25,2 +24,3 @@
+#ifndef TEST_HAS_NO_EXCEPTIONS
extern "C" void LLVMFuzzerTestOneInput(const char *data)
EricWF wrote:
> I prefer putting the `#if` on the inside of
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This approach looks great. I don't think we need to split things up into
separate files. This is exactly how `test_macros.h` should be used.
Feel free to convert as many tests as possible. I'v
rmaprath added a comment.
In https://reviews.llvm.org/D24562#542630, @mclow.lists wrote:
> What an awful test. I wonder who wrote such a steaming pile. Probably me.
I think I've thrown quite a lot of XFAILs like this in the past, just to get
the no-exceptions build passing. Now I've got to c
mclow.lists added a comment.
What an awful test. I wonder who wrote such a steaming pile. Probably me.
https://reviews.llvm.org/D24562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rmaprath updated this revision to Diff 71349.
rmaprath added a comment.
(Added more context)
https://reviews.llvm.org/D24562
Files:
test/std/re/re.alg/re.alg.search/grep.pass.cpp
Index: test/std/re/re.alg/re.alg.search/grep.pass.cpp
===
