compnerd closed this revision.
compnerd added a comment.
SVN r280988
https://reviews.llvm.org/D24314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai marked 2 inline comments as done.
smeenai added a comment.
https://reviews.llvm.org/D24314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai updated this revision to Diff 70598.
smeenai added a comment.
Simpliying conditional per EricWF's suggestion
https://reviews.llvm.org/D24314
Files:
include/support/win32/support.h
Index: include/support/win32/support.h
=
smeenai added inline comments.
Comment at: include/support/win32/support.h:48
@@ -47,2 +47,3 @@
#if defined(_LIBCPP_MSVCRT)
+#if _VC_CRT_MAJOR_VERSION < 14
#define snprintf _snprintf
EricWF wrote:
> Maybe fold these to `#if`'s into `#if defined(_VC_CRT_MAJOR_VER
EricWF added a comment.
This LGTM but I'll let @compnerd give it the final OK, since I've never built
libc++ on windows.
Comment at: include/support/win32/support.h:48
@@ -47,2 +47,3 @@
#if defined(_LIBCPP_MSVCRT)
+#if _VC_CRT_MAJOR_VERSION < 14
#define snprintf _snprintf
---
