logan added a comment.
In https://reviews.llvm.org/D24084#532724, @asl wrote:
> I totally agree with Renato. What part of libc++abi requires exactly
> libunwind's unwind.h, what is the dependency?
To be specific, we need:
- Structure Definition: `_Unwind_Control_Block` (missing from ``
bundl
asl added a comment.
I totally agree with Renato. What part of libc++abi requires exactly
libunwind's unwind.h, what is the dependency?
https://reviews.llvm.org/D24084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
rengolin added a comment.
In https://reviews.llvm.org/D24084#530427, @logan wrote:
> We can either (1) specify the path to libunwind or (2) manually download
> `unwind.h` header from libunwind project and place it to `include` directory.
That is a horrible dependency... I never hit it because
logan added a comment.
In https://reviews.llvm.org/D24084#530433, @rengolin wrote:
> That is a horrible dependency... I never hit it because I always test libc++
> with libunwind.
I think the best solution is to move/merge `libunwind/include/unwind.h` to/with
`clang/lib/Headers/unwind.h`. An
logan added a comment.
Yes. This is what we have today.
We can either (1) specify the path to libunwind or (2) manually download
`unwind.h` header from libunwind project and place it to `include` directory.
https://reviews.llvm.org/D24084
___
cfe
rengolin added a comment.
> We have to do so because we need the modified "unwind.h" from libunwind.
> (Note: which is bundled with clang/gcc is not sufficient.)
So, you need libunwind's sources, even if you're not building or using them, to
build libc++abi?
https://reviews.llvm.org/D24084
