This revision was automatically updated to reflect the committed changes.
Closed by commit rL280842: Do not validate pch when -fno-validate-pch is set
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D24054?vs=70569&id=70580#toc
Repository:
rL LLVM
https://reviews.llv
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rsmith accepted this revision.
rsmith added a comment.
It's pretty gross that we're computing `SuggestedPredefines` in the
`ASTReaderListener`, but sure, this seems OK for now.
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commit
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 70569.
yaxunl added a comment.
Herald added a subscriber: wdng.
Implemented a simple AST reader listener to replace PCHValidator. Added a test.
https://reviews.llvm.org/D24054
Files:
include/clang/Serialization
bader added a comment.
Could you a regression test, please?
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
The bug is due to PCHValidator is added as Listener, which causes pch is
validated even though DisableValidation is true (when -fno-validate-pch is on).
The fix is not add PCHValidator as listener when DisableValidation is true.
The bug is annoying for using pch. When pc
