Re: [PATCH] D23325: [WIP] Binding of references to packed fields

2016-08-30 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/Expr.h:441 @@ +440,3 @@ + /// Likewise bitfields, we model gl-values referring to packed-fields as + /// an aspect of the value-kind type system. + bool refersToPackedField() const { return getObjectKind() == OK_Packed

Re: [PATCH] D23325: [WIP] Binding of references to packed fields

2016-08-30 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:436 @@ -434,1 +435,3 @@ + /// \brief Returns true if this expression is a gl-value that + /// potentially refers to a packed-field. Here packed-field means s/gl-value/glvalue =

Re: [PATCH] D23325: [WIP] Binding of references to packed fields

2016-08-09 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 added inline comments. Comment at: lib/Sema/SemaInit.cpp:4202-4204 @@ +4201,5 @@ + + It is not possible to bind w to a temporary of a.x because this + would require (recursively) invoking the copy constructor of + std::vector to obtain first a (properly