This revision was automatically updated to reflect the committed changes.
Closed by commit rL278102: [include-fixer] Support processing multiple files in
one run. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23266?vs=67294&id=67296#toc
Repository:
rL LLVM
https:/
hokein updated this revision to Diff 67294.
hokein added a comment.
Update comments, don't mention absolute file path since this is no guarantee
about that.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
+ /// \brief The absolute path to the file being processed.
+ std::string FilePath;
---
hokein updated this revision to Diff 67178.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/In
hokein added a comment.
> Can you add a lit test for this? We should've added that earlier :|
I forgot to upload the test first time. But I have already uploaded it, see
`multiple_fixes.cpp`
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
+ /// \brief
bkramer added a comment.
Can you add a lit test for this? We should've added that earlier :|
Comment at: include-fixer/IncludeFixer.h:53
@@ -51,2 +52,3 @@
/// The context that contains all information about the symbol being queried.
+ std::vector &Contexts;
---
hokein updated this revision to Diff 67172.
hokein added a comment.
Add missing tests.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangI
hokein updated this revision to Diff 67171.
hokein added a comment.
Remove unneeded header.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/C
