This revision was automatically updated to reflect the committed changes.
Closed by commit rL278735: Add the notion of deferred diagnostics. (authored by
jlebar).
Changed prior to commit:
https://reviews.llvm.org/D23241?vs=68063&id=68073#toc
Repository:
rL LLVM
https://reviews.llvm.org/D232
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 68063.
jlebar added a comment.
Move deferred diags storage into ASTContext.
https://reviews.llvm.org/D23241
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Decl.h
clang/lib/AST/Decl.cpp
clang/lib/CodeGen/CodeGenModule.cpp
clang/
rnk added a comment.
Sorry for the delay, was trying to stay focused on debugging
Comment at: clang/include/clang/AST/Decl.h:1647
@@ +1646,3 @@
+ /// clears this list) needs to be a logically-const operation.
+ mutable std::unique_ptr> DeferredDiags;
+
Decl me
jlebar added a comment.
Reid, I'd still like you to have a look at this one if you don't mind, since
it's outside my and Art's core competencies.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2886
@@ +2885,3 @@
+ // Check if this function has diagnostics that should be emitt
jlebar updated this revision to Diff 67367.
jlebar marked an inline comment as done.
jlebar added a comment.
Address review comments, and don't abort codegen'ing a function if it has only
deferred warnings -- check specifically for errors.
https://reviews.llvm.org/D23241
Files:
clang/include/
tra added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2886
@@ +2885,3 @@
+ // Check if this function has diagnostics that should be emitted when we
+ // codegen it. If so, don't eit this function definition, but don't emit the
+ // diags just yet. Emittin
