Re: [PATCH] D23158: [clang-rename] merge tests when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL278221: [clang-rename] merge tests when possible (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23158?vs=67516&id=67517#toc Repository: rL LLVM https://reviews.llvm.org/D2

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 67516. omtcyfz added a comment. Delete two more files. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp test/clang-rename/ClassAsTemplateArgumentFindByTemplat

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 67515. omtcyfz added a comment. Update files not previouysly added with `git add`. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp test/clang-rename/ClassAsT

Re: [PATCH] D23158: [clang-rename] merge tests when possible

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D23158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 67501. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassSimpleRenaming.cpp test/clang-rename/ClassTestMulti.c

Re: [PATCH] D23158: [clang-rename] merge tests when possible

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Removing from my dashboard until the comments are addressed. https://reviews.llvm.org/D23158 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 66818. omtcyfz added a comment. Make testset great again. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp test/clang-rename/ClassAsTemplateArgumentFindByTemp

Re: [PATCH] D23158: [clang-rename] merge tests when possible

alexfh added a comment. Much better now, please also add instruction on how to find offsets. https://reviews.llvm.org/D23158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 66803. omtcyfz added a comment. Rebased on master. Removed unneeded file copying etc since clang-rename can output to the stdout. https://reviews.llvm.org/D23158 Files: test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassAsTemplateArgu

Re: [PATCH] D23158: [clang-rename] merge tests when possible

omtcyfz updated this revision to Diff 66801. omtcyfz marked an inline comment as done. https://reviews.llvm.org/D23158 Files: clang-rename/USRFindingAction.cpp clang-rename/tool/ClangRename.cpp test/clang-rename/ClassAsTemplateArgument.cpp test/clang-rename/ClassAsTemplateArgumentFindByCl

Re: [PATCH] D23158: [clang-rename] merge tests when possible

alexfh added a comment. Awesome! A few improvements are still possible though. See inline comments. Comment at: test/clang-rename/ClassAsTemplateArgument.cpp:15 @@ +14,3 @@ + +// RUN: cat %s > %t_0.cpp +// RUN: clang-rename -offset=7 -new-name=Bar %t_0.cpp -i --