zlei added a comment.
@rovka Thanks a lot :)
Repository:
rL LLVM
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rovka added a subscriber: rovka.
rovka added a comment.
Hi Lei,
Renato is on vacation, so I committed this for you.
Regards,
Diana
Repository:
rL LLVM
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277985: Fix two bugs for musl-libc on ARM (authored by
rovka).
Changed prior to commit:
https://reviews.llvm.org/D22904?vs=66074&id=67131#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22904
Fil
zlei added a comment.
@rengolin Could you please apply this patch? I don't have the permission.
Thanks.
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
zlei added a comment.
@rengolin Thanks for your comments. Patch updated.
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zlei updated this revision to Diff 66074.
zlei added a comment.
Restructure the code and add a few tests.
https://reviews.llvm.org/D22904
Files:
lib/Driver/ToolChains.cpp
test/Driver/linux-ld.c
Index: test/Driver/linux-ld.c
==
rengolin added a comment.
Hi Lei,
Thanks for the fix. A few comments. Also, please, add some tests.
cheers,
--renato
Comment at: lib/Driver/ToolChains.cpp:4266
@@ -4266,1 +4265,3 @@
+ if (Triple.isAndroid()) {
return Triple.isArch64Bit() ? "/system/bin/linker64" :
"/sys
