alexshap added a comment.
two separate observations:
1. **without my changes** :
I checked the following revision: r276508 | rsmith | 2016-07-22 19:32:21
(with gcc 4.7.4, g++ 4.7.4, Ubuntu 16.04.1 LTS)
build of llvm/clang failed, the logs are here: https://reviews.llvm.org/P6916
(emplace is one
bkramer added a comment.
As far as I know we still support GCC 4.7, which doesn't have emplace in
std::map. I don't think this patch will work with 4.7. Should we drop support
for 4.7?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
c
alexshap added a comment.
no, i don't.
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Do you have commit access?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@list
