This revision was automatically updated to reflect the committed changes.
Closed by commit rL275493: C does not have inline variables. (authored by
probinson).
Changed prior to commit:
https://reviews.llvm.org/D22113?vs=64053&id=64057#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22113
rsmith accepted this revision.
rsmith added a comment.
Thanks!
https://reviews.llvm.org/D22113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson updated this revision to Diff 64053.
probinson marked an inline comment as done.
probinson added a comment.
Reorder the checks. I didn't see any tests for the adjacent (C++) diagnostics
so I added some.
https://reviews.llvm.org/D22113
Files:
lib/Sema/SemaDecl.cpp
test/Sema/inlin
probinson marked an inline comment as done.
Comment at: lib/Sema/SemaDecl.cpp:6189-6191
@@ -6188,2 +6188,5 @@
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+} else if (!getLangOpts().CPlusPlus) {
+ Diag(D.getDeclSpec().getInlineSpecLoc(), diag:
majnemer added a subscriber: majnemer.
Comment at: lib/Sema/SemaDecl.cpp:6189-6191
@@ -6188,2 +6188,5 @@
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+} else if (!getLangOpts().CPlusPlus) {
+ Diag(D.getDeclSpec().getInlineSpecLoc(), diag::err_
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! I don't think we intended this to be an extension for C.
https://reviews.llv
probinson added a comment.
Ping.
https://reviews.llvm.org/D22113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
