rmaprath added a comment.
In http://reviews.llvm.org/D21673#467317, @mclow.lists wrote:
> Just a reminder - the people who can approve patches for libc++ are
> @mclow.lists and @ericWF.
My bad, I thought it was too trivial. Won't happen again :)
/ Asiri
Repository:
rL LLVM
http://reviews
mclow.lists added subscribers: EricWF, mclow.lists.
mclow.lists added a comment.
Just a reminder - the people who can approve patches for libc++ are
@mclow.lists and @ericWF.
Repository:
rL LLVM
http://reviews.llvm.org/D21673
___
cfe-commits mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273697: [libcxx] guard throw with exception enabling check
(authored by weimingz).
Changed prior to commit:
http://reviews.llvm.org/D21673?vs=61755&id=61813#toc
Repository:
rL LLVM
http://reviews.ll
rmaprath added a comment.
In http://reviews.llvm.org/D21673#466544, @weimingz wrote:
> It's a good idea. Currently, there are about 600+ "throws" being
> guarded by _LIBCPP_NO_EXCEPTIONS macro.
>
> How about let's merge the patch now and I can do the conversion of
> existing code to the wrap
weimingz added a subscriber: weimingz.
weimingz added a comment.
It's a good idea. Currently, there are about 600+ "throws" being
guarded by _LIBCPP_NO_EXCEPTIONS macro.
How about let's merge the patch now and I can do the conversion of
existing code to the wrapper in background?
Weiming
ht
It's a good idea. Currently, there are about 600+ "throws" being
guarded by _LIBCPP_NO_EXCEPTIONS macro.
How about let's merge the patch now and I can do the conversion of
existing code to the wrapper in background?
Weiming
On 6/24/2016 1:25 AM, Noel Grandin wrote:
grandinj added a subscri
grandinj added a subscriber: grandinj.
Comment at: include/experimental/optional:524
@@ -521,1 +523,3 @@
+assert(!"bad optional access");
+#endif
return this->__val_;
If this kind of code is going to show up in lots of places, then maybe wrap
rmaprath added a subscriber: rmaprath.
rmaprath accepted this revision.
rmaprath added a reviewer: rmaprath.
rmaprath added a comment.
This revision is now accepted and ready to land.
That looks fine to me.
http://reviews.llvm.org/D21673
___
cfe-com
