Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

2016-07-22 Thread Piotr Padlewski via cfe-commits
Prazek marked 3 inline comments as done. Comment at: test/clang-tidy/boost-use-to-string.cpp:154 @@ +153,3 @@ + float floating; + Fields* wierd; + const int &getConstInteger() const {return integer;} alexfh wrote: > alexfh wrote: > > "wierd" is weird ;) > I sho

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

2016-06-28 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:154 @@ +153,3 @@ + float floating; + Fields* wierd; + const int &getConstInteger() const {return integer;} alexfh wrote: > "wierd" is weird ;) I should have been more clear in the

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

2016-06-28 Thread Piotr Padlewski via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274001: [clang-tidy] boost-use-to-string arg expr location bugfix (authored by Prazek). Changed prior to commit: http://reviews.llvm.org/D21642?vs=61665&id=62069#toc Repository: rL LLVM http://revie

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

2016-06-26 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Comment at: test/clang-tidy/boost-use-to-string.cpp:154 @@ +153,3 @@ + float floating; + Fields* wierd; + const int &getConstInteger() const {retu

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

2016-06-25 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. ping anyone. This is nobrainer fix. http://reviews.llvm.org/D21642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

2016-06-23 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 61665. Prazek added a comment. - small fix http://reviews.llvm.org/D21642 Files: clang-tidy/boost/UseToStringCheck.cpp test/clang-tidy/boost-use-to-string.cpp Index: test/clang-tidy/boost-use-to-string.cpp ===