Re: [PATCH] D20887: [libcxx] Allow target flags to affect CMake configuration tests

2016-06-01 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 59325. EricWF added a comment. Address review comments. Add "=" sign in sysroot. http://reviews.llvm.org/D20887 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake Index: cmake/Modules/HandleLibcxxFlags.cmake

Re: [PATCH] D20887: [libcxx] Allow target flags to affect CMake configuration tests

2016-06-01 Thread Saleem Abdulrasool via cfe-commits
compnerd requested changes to this revision. This revision now requires changes to proceed. Comment at: CMakeLists.txt:259 @@ +258,3 @@ +add_target_flags_if(LIBCXX_TARGET_TRIPLE "-target ${LIBCXX_TARGET_TRIPLE}") +add_target_flags_if(LIBCXX_SYSROOT "--sysroot ${LIBCXX_SYSROOT}") +