Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

2016-05-19 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270160: [Lexer] Don't merge macro args from different macro files (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D20401?vs=57810&id=57880#toc Repository: rL LLVM http://revi

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

2016-05-19 Thread Vedant Kumar via cfe-commits
Yes, here are the results from the unpatched compiler: Avg. wall time (s): 0.73241 Std. deviation: 0.05850 And here are the results from the patched compiler: Avg. wall time (s): 0.75554 Std. deviation: 0.07492 The testing methodology was the same (100 trials), except I used `clang -x objectiv

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

2016-05-19 Thread Argyrios Kyrtzidis via cfe-commits
Could you also check performance of creating a PCH file out of Cocoa.h ? > On May 19, 2016, at 1:47 PM, Vedant Kumar wrote: > > vsk added a comment. > > I discussed this bug with Argyrios off-list, who lgtm'd on the condition that > it doesn't introduce a performance regression. He suggested p

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

2016-05-19 Thread Vedant Kumar via cfe-commits
vsk added a comment. I discussed this bug with Argyrios off-list, who lgtm'd on the condition that it doesn't introduce a performance regression. He suggested preprocessing Cocoa.h to stress the patch. After running a stabilization script, I used this command to stress RelNoAsserts builds of cl

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

2016-05-19 Thread Vedant Kumar via cfe-commits
vsk updated this revision to Diff 57810. vsk added a comment. - Fix explanation of the test case in test/CoverageMapping. http://reviews.llvm.org/D20401 Files: lib/Lex/TokenLexer.cpp test/CoverageMapping/Inputs/macros.h test/CoverageMapping/include-macros.c unittests/Lex/LexerTest.cpp

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

2016-05-18 Thread Vedant Kumar via cfe-commits
vsk updated this revision to Diff 57711. vsk added a comment. - Add some comments to the unit test. http://reviews.llvm.org/D20401 Files: lib/Lex/TokenLexer.cpp test/CoverageMapping/Inputs/macros.h test/CoverageMapping/include-macros.c unittests/Lex/LexerTest.cpp Index: unittests/Lex/L