aaron.ballman added a comment.
In http://reviews.llvm.org/D20366#433204, @hokein wrote:
> In http://reviews.llvm.org/D20366#433123, @aaron.ballman wrote:
>
> > What's the harm in leaving the props at 0644?
>
>
> Just inconvenient . And I see the `dump_format_style.py` in the same
> directory is
hokein added a comment.
In http://reviews.llvm.org/D20366#433123, @aaron.ballman wrote:
> What's the harm in leaving the props at 0644?
Just inconvenient . And I see the `dump_format_style.py` in the same directory
is executable.
http://reviews.llvm.org/D20366
aaron.ballman added a comment.
In http://reviews.llvm.org/D20366#433103, @hokein wrote:
> In http://reviews.llvm.org/D20366#433054, @aaron.ballman wrote:
>
> > Yeah, I'm not certain either (I've never used phab for reviewing this sort
> > of thing). I would prefer this to be 0744 so that it is n
hokein added a comment.
In http://reviews.llvm.org/D20366#433054, @aaron.ballman wrote:
> Yeah, I'm not certain either (I've never used phab for reviewing this sort of
> thing). I would prefer this to be 0744 so that it is not group or world
> executable.
No idea on this now. I tried `chmod 7
aaron.ballman added a comment.
In http://reviews.llvm.org/D20366#433052, @hokein wrote:
> I don't why the diff shows 755 here. But in my local directory, it's
> `rwxr--r--`.
Yeah, I'm not certain either (I've never used phab for reviewing this sort of
thing). I would prefer this to be 0744 so
hokein added a comment.
I don't why the diff shows 755 here. But in my local directory, it's
`rwxr--r--`.
http://reviews.llvm.org/D20366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
