Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

2016-05-02 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268261: Expand aggregate arguments more often on 32-bit Windows (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D19756?vs=55695&id=55845#toc Repository: rL LLVM http://reviews.ll

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

2016-05-02 Thread Reid Kleckner via cfe-commits
rnk marked an inline comment as done. rnk added a comment. In http://reviews.llvm.org/D19756#417718, @hans wrote: > This is awesome! lgtm Great! > Want to reference PR27522 in the patch description? > > Also in the description: > > > I also expanded the workaround handle C++ records with

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

2016-04-29 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. This is awesome! lgtm I only have nits and questions. Want to reference PR27522 in the patch description? Also in the description: > I also expanded the workaround handle C++ records with constr