Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-06-14 Thread Adam Nemet via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272656: Add loop pragma for Loop Distribution (authored by anemet). Changed prior to commit: http://reviews.llvm.org/D19403?vs=55445&id=60665#toc Repository: rL LLVM http://reviews.llvm.org/D19403

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-06-13 Thread Adam Nemet via cfe-commits
anemet added a comment. Thanks, Aaron! http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-06-13 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. I think Richard has had sufficient time to comment. You should be fine to commit and we can deal with any problems post-commit. http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-06-13 Thread Adam Nemet via cfe-commits
anemet added a comment. Ping^3 http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-05-09 Thread Adam Nemet via cfe-commits
anemet added a comment. Ping. (I am getting a bit concerned that because this was already marked accepted, it does not show up @rsmith' active queue...) http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-05-02 Thread Adam Nemet via cfe-commits
anemet added a comment. @rsmith, hi! Do you have any comments on this or you're OK with this per Aaron's LGTM? Thanks, Adam http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-04-28 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should wait in case @rsmith has feedback. http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-04-28 Thread Adam Nemet via cfe-commits
anemet updated this revision to Diff 55445. anemet added a comment. A little tweak to the example to make it clear that 'i' is the induction variable http://reviews.llvm.org/D19403 Files: docs/LanguageExtensions.rst include/clang/Basic/Attr.td include/clang/Basic/DiagnosticParseKinds.td

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-04-28 Thread Adam Nemet via cfe-commits
anemet updated this revision to Diff 55439. anemet added a comment. Added more context to the documentation per Aaron's comments. http://reviews.llvm.org/D19403 Files: docs/LanguageExtensions.rst include/clang/Basic/Attr.td include/clang/Basic/DiagnosticParseKinds.td lib/CodeGen/CGLoopI

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-04-28 Thread Adam Nemet via cfe-commits
anemet added inline comments. Comment at: docs/LanguageExtensions.rst:2161 @@ +2160,3 @@ + + #pragma clang loop distribute(enable) + for(...) { aaron.ballman wrote: > It would be nice to use a more compelling example than an empty for loop. > Also, it would be

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-04-28 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: docs/LanguageExtensions.rst:2161 @@ +2160,3 @@ + + #pragma clang loop distribute(enable) + for(...) { It would be nice to use a more compelling example than an empty for loop. Also, it would be helpful if the use