Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet closed this revision. courbet added a comment. This was submitted as r272386. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

Just ask Chris for the access :) 03.06.2016 11:26 AM "Clement Courbet via cfe-commits" < cfe-commits@lists.llvm.org> napisał(a): > courbet added a comment. > > @sbenza @aaron.ballman I don't have write access. Can one of you submit > this on my behalf ? Thanks ! > > > http://reviews.llvm.org/D1932

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. That could work :) I'm not sure my commit history is considered a "track record of submitting high quality patches" but I'll give it a try. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. @sbenza @aaron.ballman I don't have write access. Can one of you submit this on my behalf ? Thanks ! http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 59502. courbet added a comment. Rebase on origin/master http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.c

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

sbenza added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + typedef llvm::iterator_range + overridden_method_range; Sure. Sorry about that. The mai

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet marked 10 inline comments as done. courbet added a comment. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3776 @@ +3775,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder OverriddenBuilder(*Builder); Thanks for the poin

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 57757. courbet added a comment. clang-format diff http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp l

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 57756. courbet added a comment. Rebase on HEAD. http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp lib

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder OverriddenBuilder(*Builder); courbet wrote

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. Thanks. Could please you submit this for me ? Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder OverriddenBuilder(*Buil

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 57473. courbet added a comment. cometics http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp lib/AST/De

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with one minor nit. Thank you for working on this! Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 57462. courbet added a comment. Use iterator_range instead of ArrayRef for overridden_methods http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatcher

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const; aaron.ballman

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const; courbet

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const; aaron.ballman

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const; This is

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 56006. courbet marked an inline comment as done. courbet added a comment. implement overridden_methods_begin()/end() in terms of overridden_methods(). http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

sbenza added inline comments. Comment at: include/clang/AST/DeclCXX.h:1830 @@ -1829,2 +1829,3 @@ unsigned size_overridden_methods() const; + const ArrayRef overridden_methods() const; Return type should have have toplevel `const`. Comment a

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 54830. courbet marked an inline comment as done. courbet added a comment. overridden_methods return ArrayRef instead of TinyPtrVector* http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

sbenza added inline comments. Comment at: lib/AST/ASTContext.cpp:1279 @@ -1282,1 +1278,3 @@ +const ASTContext::CXXMethodVector * +ASTContext::overridden_methods(const CXXMethodDecl *Method) const { llvm::DenseMap::const_iterator Pos It would be simpler to retur

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 54514. courbet added a comment. Regenerate doc. http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp lib

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet marked an inline comment as done. courbet added a comment. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 54512. courbet marked 4 inline comments as done. courbet added a comment. - add overridden_methods() to CXXMethodDecl and plumbing. - Use range-based for loop for iterating over overridden methods. http://reviews.llvm.org/D19324 Files: include/clang/AST/A

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (auto It = Node.begin_overridden_methods(); + It != Node.end_overridden_methods(); ++It) { courbet wrote: > aaron.ball

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (auto It = Node.begin_overridden_methods(); + It != Node.end_overridden_methods(); ++It) { aaron.ballman wrote: > Can you ra

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2084 @@ +2083,3 @@ + Code1, ForEachOverriddenInClass("C"), + new VerifyIdIsBoundTo("override", "f", 1))); + EXPECT_TRUE(matchAndVerifyResultTrue( aaron.ballman wrote: >

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Please run clang\docs\tools\dump_ast_matchers.py to regenerate the documentation as well. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 54462. courbet marked an inline comment as done. courbet added a comment. Fix typo in doc. http://reviews.llvm.org/D19324 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTest.cpp In

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

mgrang added a subscriber: mgrang. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3719 @@ +3718,3 @@ +/// matches twice, once with "b" binding "A1::f" and "d" binding "C::f", and +/// once with "b" binding "A2::f" and "d" binding "C::f", and +AST_MATCHER_P(CXXMethodDecl,