Re: [PATCH] D18473: AMDGPU: Add test for generic builtin behavior

2016-04-14 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r266383 http://reviews.llvm.org/D18473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18473: AMDGPU: Add test for generic builtin behavior

2016-04-13 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Basic/Targets.cpp:1854-1857 @@ -1853,1 +1853,6 @@ + bool isCLZForZeroUndef() const override { +// It is -1 instead of expected for intrinsic. +return true; + } + --

Re: [PATCH] D18473: AMDGPU: Add test for generic builtin behavior

2016-04-12 Thread Matt Arsenault via cfe-commits
arsenm added inline comments. Comment at: lib/Basic/Targets.cpp:1854-1857 @@ -1853,1 +1853,6 @@ + bool isCLZForZeroUndef() const override { +// It is -1 instead of expected for intrinsic. +return true; + } + tstellarAMD wrote: > Why do we need to add t

Re: [PATCH] D18473: AMDGPU: Add test for generic builtin behavior

2016-03-28 Thread Tom Stellard via cfe-commits
tstellarAMD added inline comments. Comment at: lib/Basic/Targets.cpp:1854-1857 @@ -1853,1 +1853,6 @@ + bool isCLZForZeroUndef() const override { +// It is -1 instead of expected for intrinsic. +return true; + } + Why do we need to add this if it's the