Re: [PATCH] D18015: Make functions in altivec.h be inline.

2016-03-11 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Formatted and submitted as r263302. http://reviews.llvm.org/D18015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18015: Make functions in altivec.h be inline.

2016-03-11 Thread Eric Christopher via cfe-commits
echristo added a comment. Since you're changing everything anyways? Sure why not! :) -eric http://reviews.llvm.org/D18015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18015: Make functions in altivec.h be inline.

2016-03-11 Thread Daniel Jasper via cfe-commits
djasper added a comment. Want me to run clang-format on the file/diff? http://reviews.llvm.org/D18015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18015: Make functions in altivec.h be inline.

2016-03-11 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM, nice catch Daniel. (Yes, weird that nothing changed in the IR, but the patch is correct). -eric http://reviews.llvm.org/D18015 ___ cf