Re: [PATCH] D17941: add fix-its for format-security warnings

2016-03-11 Thread Bob Wilson via cfe-commits
bob.wilson accepted this revision. bob.wilson added a reviewer: bob.wilson. bob.wilson added a comment. This revision is now accepted and ready to land. Thanks Ben. Committed in r263299 http://reviews.llvm.org/D17941 ___ cfe-commits mailing list cfe

Re: [PATCH] D17941: add fix-its for format-security warnings

2016-03-08 Thread Ben Craig via cfe-commits
bcraig added a comment. LGTM. I don't have a lot of authority over this code, so you may want to get a separate LGTM from someone else. http://reviews.llvm.org/D17941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D17941: add fix-its for format-security warnings

2016-03-08 Thread Bob Wilson via cfe-commits
bob.wilson added a comment. In http://reviews.llvm.org/D17941#369698, @bcraig wrote: > What about wprintf? Do we currently warn for wprintf(str)? If so, then the > fixit probably needs to involve L"%ls". Darwin does not mark wprintf functions with an attribute. Linux (at least the version I

Re: [PATCH] D17941: add fix-its for format-security warnings

2016-03-08 Thread Ben Craig via cfe-commits
bcraig added a comment. What about wprintf? Do we currently warn for wprintf(str)? If so, then the fixit probably needs to involve L"%ls". http://reviews.llvm.org/D17941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or