Eugene.Zelenko added a comment.
It's fine. I just walk through all accepted revisions to find forgotten ones.
https://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Correct. I haven't had a chance to get back to this. I'm aiming to pick it up
again in the next week or two, but if this is specifically blocking you, feel
free to rebase and commit on my behalf.
> On 2016-Sep-26, at 13:39, Eugene Zelenko wrote:
>
> Eugene.Zelenko added a subscriber: Eugene.
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/libcxx/test/config.py:66
@@ -65,3 +65,3 @@
self.env = {}
self.use_target = False
self.use_system_cxx_lib = False
mclow.lists added a comment.
This direction looks fine to me. All the test changes look fine to me.
http://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Does anyone have a problem with this direction? I have commits to
follow that get tests green when run against various releases of OSX
but I need this in place first.
http://reviews.llvm.org/D17469
___
Does anyone have a problem with this direction? I have commits to
follow that get tests green when run against various releases of OSX
but I need this in place first.
> On 2016-Feb-19, at 17:59, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> dexonsmith created this revision.
> dexonsmith