mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
> Saving a larger locale refactor for later (but oh boy is it coming).
Looking forward to it.
http://reviews.llvm.org/D16639
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 47328.
bcraig added a comment.
Moved the CATOPEN config check back to __config. Saving a larger locale
refactor for later (but oh boy is it coming).
http://reviews.llvm.org/D16639
Files:
include/__config
Ind
mclow.lists added a comment.
I don't have a problem with this change (assuming that it is correct, and it
looks correct), but I think it should stay in __config, with all the other
configuration tests. (There are other configuration tests in the .cpp files,
but users never see those).
FWIW, l
bcraig updated this revision to Diff 46291.
bcraig added a comment.
CloudABI doesn't define __unix__, so stop blacklisting it explicitly and let
the whitelist filter it out.
http://reviews.llvm.org/D16639
Files:
include/__config
include/locale
Index: include/locale
===
ed added a comment.
I'm usually not a big fan of using definitions such as `__unix__`, because it
is pretty vague and defined inconsistently. That said, if you're going to use
this definition, then there is some good news: CloudABI doesn't define it,
meaning that you could just remove it from t
