This revision was automatically updated to reflect the committed changes.
Closed by commit rL270878: [OpenMP] Parsing and sema support for target update
directive (authored by sfantao).
Changed prior to commit:
http://reviews.llvm.org/D15944?vs=58469&id=58647#toc
Repository:
rL LLVM
http://
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D15944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
sfantao updated this revision to Diff 58469.
sfantao marked an inline comment as done.
sfantao added a comment.
- Add nestings test.
http://reviews.llvm.org/D15944
Files:
include/clang-c/Index.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/StmtOpenMP.h
include/clang/Basic/D
ABataev added a comment.
Add a test for nesting of regions here
Comment at: lib/Parse/ParseOpenMP.cpp:42
@@ -42,1 +41,3 @@
+ OMPD_target_exit,
+ OMPD_update
};
Please, add a comma after 'OMPD_update' to reduce number of changes in the next
modification of th
sfantao updated this revision to Diff 58368.
sfantao added a comment.
Add parsing and sema support only for target update and already existing
clauses (if and device).
http://reviews.llvm.org/D15944
Files:
include/clang-c/Index.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/
kkwli0 added a comment.
Patch for the to and from clauses is in http://reviews.llvm.org/D18488.
http://reviews.llvm.org/D15944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 added a comment.
Thanks for the review.
As request, I will split this patch into two:
1. to and from clause (without test cases)
2. target update directive (with test cases)
I will use this review for the target update directive.
http://reviews.llvm.org/D15944
__
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:3466
@@ -3465,1 +3465,3 @@
};
+
+/// \brief This represents clause 'from' in the '#pragma omp ...'
New clauses must be added in separate patches
http://reviews.llvm.org/D15944
_
sfantao added a comment.
Thanks Kelvin,
I'm fine with the patch. Let's wait for Alexey to see if he has any concern.
Thanks again!
Samuel
http://reviews.llvm.org/D15944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
kkwli0 updated this revision to Diff 50774.
kkwli0 marked 5 inline comments as done.
kkwli0 added a comment.
Addressed the comments from the last review: added assert calls and outline the
common code in ActOnOpenMPToClause, ActOnOpenMPFromClause and
ActOnOpenMPMapClause to a static function.
sfantao added a comment.
Hi Kelvin,
Thanks for working on this! I have some minor comments inlined.
Comment at: lib/Sema/SemaOpenMP.cpp:9392
@@ +9391,3 @@
+ SemaRef.Diag(ELoc, diag::err_omp_map_shared_storage) << ERange;
+else
+ SemaRef.Dia
kkwli0 updated this revision to Diff 50024.
kkwli0 marked 2 inline comments as done.
kkwli0 added a comment.
I rebase the patch to the latest trunk and make use of the infrastructure form
parsing and sema.
http://reviews.llvm.org/D15944
Files:
include/clang-c/Index.h
include/clang/AST/Open
kkwli0 marked 3 inline comments as done.
Comment at: include/clang/AST/OpenMPClause.h:3196
@@ -3195,1 +3195,3 @@
+/// \brief This represents clause 'from' in the '#pragma omp ...'
+/// directives.
ABataev wrote:
> New clauses must be added in separate patches af
ABataev added a comment.
Kelvin, thanks for the patch!
One more comment: what about nesting of regions? You need to add a
corresponding code and tests
Comment at: include/clang/AST/OpenMPClause.h:3196
@@ -3195,1 +3195,3 @@
+/// \brief This represents clause 'from' in the '#pr
14 matches
Mail list logo
