Re: [PATCH] D15853: [PGO]: Simplify coverage data lowering code

2016-08-01 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Done in clang/r257092 https://reviews.llvm.org/D15853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D15853: [PGO]: Simplify coverage data lowering code

2016-08-01 Thread Vedant Kumar via cfe-commits
vsk closed this revision. vsk added a comment. Closing old review https://reviews.llvm.org/D15853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15853: [PGO]: Simplify coverage data lowering code

2016-01-18 Thread David Li via cfe-commits
davidxl added a comment. I missed the review comments earlier. The local var name is fixed. The getCoverageNamesVarName API name will be fixed later. Regarding to your question: the patch does not not change the behavior of the name handling. For all used functions, their names are handled in

Re: [PATCH] D15853: [PGO]: Simplify coverage data lowering code

2016-01-06 Thread David Li via cfe-commits
davidxl updated this revision to Diff 44127. davidxl added a comment. Update patch to reduce overhead: Only record names for unused functions. http://reviews.llvm.org/D15853 Files: lib/CodeGen/CodeGenPGO.cpp lib/CodeGen/CoverageMappingGen.cpp lib/CodeGen/CoverageMappingGen.h Index: lib/C