dcoughlin added a comment.
Thanks for patch! Some comments inline.
You don't have to do it in this patch, but I think it would be good to get this
working with AddImplicitDtors. I think it would also be good to (eventually)
add CFGElements marking when the storage duration for underlying storag
mgehre added a comment.
Friendly ping
https://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre added a comment.
Ping
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre updated this revision to Diff 53261.
mgehre added a comment.
Remove unused CFGBuilder::prependLifetimeEndsWithTerminator
http://reviews.llvm.org/D15031
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CFG.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
mgehre updated this revision to Diff 53092.
mgehre added a comment.
Fix assert in LocalScope::const_iterator::distance when using goto to jump over
trivially constructable variable declarations
Added two test cases for this
http://reviews.llvm.org/D15031
Files:
include/clang/Analysis/Analysi
mgehre updated this revision to Diff 52959.
mgehre added a comment.
Update for review comments
- Change name from ObjLeavesScope to LifetimeEnds
- Make sure that trivially destructible objects end their lifetime after
non-trivial destructible objects
- Add test
- Add analyzer option to enable Li
mgehre added a comment.
By the way, is there a tool to generate parts of the test based on clang
output, i.e.
something that will prefix the output of clang with "CHECK: " and "CHECK-NEXT:"
so I can copy-and-paste
it into my test file?
http://reviews.llvm.org/D15031
mgehre added inline comments.
Comment at: include/clang/Analysis/CFG.h:170
@@ -168,1 +169,3 @@
+class CFGAutomaticObjLeavesScope : public CFGElement {
+public:
rsmith wrote:
> What is this intended to model? There seem to be a few options here:
>
> 1) The poin
a.sidorin added a subscriber: a.sidorin.
a.sidorin added a comment.
Matthias,
Could you take a look at http://reviews.llvm.org/D16403? It looks like a
duplicating work but it should cover not Objective-C only.
http://reviews.llvm.org/D15031
___
cf
mgehre added a comment.
Thank you very much for your review. I'm sorry that I'm currently quite busy,
but I will find some time to answer at the end of this week.
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
rsmith added a comment.
Please add a test that builds and dumps a CFG and checks it has the right
shape. It's generally not sufficient for the only tests for one LLVM project to
exist in a different LLVM project. See test/Analysis/cfg.cpp for an example of
how to do this.
Com
alexfh added a subscriber: alexfh.
alexfh added a comment.
Richard, can you review this?
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre added a comment.
The lifetime checker that needs this is at http://reviews.llvm.org/D15032
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
13 matches
Mail list logo
