ismail added a comment.
Reverted in r257468.
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM with some tests cases.
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
martell updated this revision to Diff 42933.
martell added a comment.
Sorry I was a bit slow getting around to this.
Will do testcases if Yaron thinks this is okay
http://reviews.llvm.org/D15006
Files:
lib/Driver/MinGWToolChain.cpp
lib/Driver/ToolChains.h
Index: lib/Driver/ToolChains.h
==
martell added a comment.
hi ismail,
I will tidy up for review closer towards the weekend where i can work on out of
work stuff
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
ismail added a comment.
Martell, any update on this?
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added a comment.
findGccDir() can return llvm::ErrorOr and then all Base
assignments happen at the same if-elseif-else:
if (getDriver().SysRoot.size())
Base = getDriver().SysRoot;
else if (llvm::ErrorOr GPPName = findGccDir())
Base = llvm::sys::path::parent_path(
ismail added a comment.
Tested on openSUSE and it works. Thanks!
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell updated this revision to Diff 41209.
martell added a comment.
Updated to reflect feedback
I'm not too sure what todo for testcases on this one because they already exist
for the most part.
I ran the test suite and they all pass.
I would have to create a mingw32-gcc and {armv7|i686|x86_6
yaron.keren added a comment.
This always searches for something-gcc and then discards the result if sysroot
was provided, which is a waste.
Move the searching to a helper function and then it can be done only if sysroot
was not provided, as it is now.
The break is needed to avoid looking for mi
martell added a comment.
@ismail can you test this for your setup please? :)
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell updated the summary for this revision.
martell updated this revision to Diff 41208.
martell added a comment.
Removed the break that I didn't think was needed
Can be re-added ??
Will added testcases
http://reviews.llvm.org/D15006
Files:
lib/Driver/MinGWToolChain.cpp
Index: lib/Driver
11 matches
Mail list logo
