angelgarcia updated this revision to Diff 37859.
angelgarcia added a comment.
Remove the fixme.
http://reviews.llvm.org/D13871
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultCheck.cpp
clang-tidy/modernize/UseDefault
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. Yay!
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:59-60
@@ +58,4 @@
+ "= default;");
+ // FIXME: this can generate a -Wpedantic warning if there is a sem
angelgarcia updated this revision to Diff 37833.
angelgarcia added a comment.
Global variable -> static, and a few other additions.
> Will be good idea to add handling of cases where default constructor is empty
> and only call base class(es) default constructor/members default constructors
I
george.burgess.iv added a subscriber: george.burgess.iv.
george.burgess.iv added a comment.
This looks like a good check -- thanks for adding it! Just one small nit for
you.
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:19
@@ +18,3 @@
+
+const char CtorDtor[] = "CtorDtor
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Will be good idea to add handling of cases where default constructor is empty
and only call base class(es) default constructor/members default constructors
(see http://en.cppreference.com/w/cpp/language/default_co
