Re: [PATCH] D12580: Added StrictVTablePointers linking requirement

2015-09-03 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D12580: Added StrictVTablePointers linking requirement

2015-09-03 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 33969. http://reviews.llvm.org/D12580 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/strict-vtable-pointers.cpp Index: test/CodeGenCXX/strict-vtable-pointers.cpp === --- test/CodeGenCXX

Re: [PATCH] D12580: Added StrictVTablePointers linking requirement

2015-09-03 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. I see that CGObjCMac.cpp names it like this: "Objective-C Garbage Collection" http://reviews.llvm.org/D12580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12580: Added StrictVTablePointers linking requirement

2015-09-02 Thread Richard Smith via cfe-commits
rsmith added a comment. Functionally LGTM, but please add a test case. Is there any precedent for how to spell these module flags (StrictVTablePointers / strict_vtable_pointers / strict.vtable.pointers)? http://reviews.llvm.org/D12580 ___ cfe-comm