RE: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread via cfe-commits
I thin the Best Fix is probably to make FileCheck diag if a line starts with (after a few whitelisted comment chars like // and #) a check-prefix but then isn't followed by : (maybe after -NOT, -SAME, -LABEL etc). FileCheck doesn't explicitly pass over leading comment characters, it just patter

Re: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread Nico Weber via cfe-commits
On Mon, Feb 11, 2019 at 11:38 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits > wrote: > > > > Author: nico > > Date: Mon Feb 11 08:37:02 2019 > > New Revision: 353718 > > > > URL: http://llvm.org/viewvc/llvm-proj

Re: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread Roman Lebedev via cfe-commits
On Mon, Feb 11, 2019 at 7:38 PM Aaron Ballman via cfe-commits wrote: > > On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits > wrote: > > > > Author: nico > > Date: Mon Feb 11 08:37:02 2019 > > New Revision: 353718 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev > > L

Re: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread Aaron Ballman via cfe-commits
On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits wrote: > > Author: nico > Date: Mon Feb 11 08:37:02 2019 > New Revision: 353718 > > URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev > Log: > Make test actually test something (colons were missing) Good catch! I wonder if we